Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement DELEGATECALL and CALLCODE #159

Merged
merged 4 commits into from
Aug 5, 2023
Merged

Conversation

daejunpark
Copy link
Collaborator

No description provided.

Comment on lines +17 to +18
sstore(codesize_.slot, codesize())
sstore(extcodesize_.slot, extcodesize(address()))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah interesting 👌

Comment on lines +106 to +107
vm.deal(address(d), 0);
vm.deal(address(d.c()), 0);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the deal 0s?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

balance is not assumed to be zero, because someone might have already sent fund to accounts before created.

Copy link
Collaborator

@karmacoma-eth karmacoma-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@daejunpark daejunpark merged commit 6602b9d into main Aug 5, 2023
91 checks passed
@daejunpark daejunpark deleted the feat/delegatecall branch August 5, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants